Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add env var to set triplestore actor pool #1537

Merged
merged 8 commits into from
Jan 15, 2020

Conversation

loicjaouen
Copy link
Contributor

The application.conf sets many parameters.

Some are hard coded to be changed once in a blue moon, others are more accessible through the setting of environment variables.

This PR is to allow such environment variable to set the size of the thread pool dedicated to querying the tripple store.

@loicjaouen loicjaouen added enhancement improve existing code or new feature f:reliability labels Nov 28, 2019
@loicjaouen loicjaouen requested a review from subotic November 28, 2019 17:14
@loicjaouen loicjaouen self-assigned this Nov 28, 2019
@loicjaouen
Copy link
Contributor Author

@subotic , testing this takes longer than expected I tested the effect on a local run, but it also needs to run in the images as we set-up stacks for deployment. So could you already have a look at the changes to check if something obviously wrong meets your eyes?

@subotic subotic changed the title adding an env var to set graphdb pool size build: Add env var to set triplestore actor pool Nov 28, 2019
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@loicjaouen loicjaouen merged commit 19239b2 into develop Jan 15, 2020
@loicjaouen loicjaouen deleted the wip/configurable-pool-size branch January 15, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants