DSP-932: Don't allow missing StringLiteralV2 value if language tag given #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SepidehAlassi
changed the title
benjamingeer
approved these changes
Oct 29, 2020
|
|
||
| val thrown = the [BadRequestException] thrownBy payload.parseJson.convertTo[CreateListApiRequestADM] | ||
|
|
||
| thrown.getMessage should equal ("String value is missing.") |
There was a problem hiding this comment.
I'm generally reluctant to check the contents of exception messages in tests, because exception messages often change over time, and then it's annoying to have to fix a lot of tests. But it's up to you.
There was a problem hiding this comment.
@benjamingeer yeah, I need to check them. It is my paranoia ;-)
|
@benjamingeer Thanks for reviewing this. I just added a general test for directly checking |
|
OK that looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-932
closes #1418