-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: knora upload scripts and configs #174
Conversation
"make check" now reports no error!!
There is still something not right, or at least something about the automatically generated sub-directories that I don't understand. |
…l/Sipi into wip/fix-knora-scripts
@benjamingeer I was part of the PR so maybe you should do the review. |
OK but I don't know what this is for, please write a description for the PR explaining what was changed. |
I've added a summary in the description. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there's a working test framework, could you add a test for this feature? I think it would be especially good to have a test of the feature that automatically restructures existing files into subdirectories when the Sipi server starts. Especially if there are a large number of existing files.
Gladly, if it is ok to create an issue for this and do it in another PR? I need this pull request merged so that I can merge dasch-swiss/dsp-api#534. Also, need to work on another pile more urgently ;-) |
Created issue #177 |
OK! |
Thanks :-) |
Summary
subdir_levels
featuresubdir_exludes
list with directories which should be skipped by sipiwwwroute
in config files