Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: knora upload scripts and configs #174

Merged
merged 18 commits into from
Jun 23, 2017
Merged

Conversation

lrosenth
Copy link
Collaborator

@lrosenth lrosenth commented Jun 21, 2017

Summary

  • update Knora scripts to work with new subdir_levels feature
  • add subdir_exludes list with directories which should be skipped by sipi
  • rename wwwroute in config files
  • add better error output in LuaServer now containing the name of the script failing

@subotic subotic changed the title fix (scripts): knora upload scripts fix: knora upload scripts and configs Jun 21, 2017
@subotic subotic self-assigned this Jun 21, 2017
@subotic subotic added this to the On Deck milestone Jun 21, 2017
"make check" now reports no error!!
@subotic
Copy link
Contributor

subotic commented Jun 22, 2017

There is still something not right, or at least something about the automatically generated sub-directories that I don't understand.

@subotic subotic requested a review from benjamingeer June 23, 2017 13:51
@subotic
Copy link
Contributor

subotic commented Jun 23, 2017

@benjamingeer I was part of the PR so maybe you should do the review.

@benjamingeer
Copy link
Contributor

OK but I don't know what this is for, please write a description for the PR explaining what was changed.

@subotic
Copy link
Contributor

subotic commented Jun 23, 2017

I've added a summary in the description. Thanks.

Copy link
Contributor

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there's a working test framework, could you add a test for this feature? I think it would be especially good to have a test of the feature that automatically restructures existing files into subdirectories when the Sipi server starts. Especially if there are a large number of existing files.

@subotic
Copy link
Contributor

subotic commented Jun 23, 2017

Gladly, if it is ok to create an issue for this and do it in another PR? I need this pull request merged so that I can merge dasch-swiss/dsp-api#534.

Also, need to work on another pile more urgently ;-)

@subotic
Copy link
Contributor

subotic commented Jun 23, 2017

Created issue #177

@benjamingeer
Copy link
Contributor

OK!

@subotic
Copy link
Contributor

subotic commented Jun 23, 2017

Thanks :-)

@subotic subotic merged commit 51054d0 into develop Jun 23, 2017
@subotic subotic deleted the wip/fix-knora-scripts branch June 24, 2017 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants