Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add mimetype to knora json response #305

Merged
merged 3 commits into from
Oct 2, 2019
Merged

feature: Add mimetype to knora json response #305

merged 3 commits into from
Oct 2, 2019

Conversation

lrosenth
Copy link
Collaborator

@lrosenth lrosenth commented Oct 1, 2019 •
edited by subotic
Loading

@lrosenth lrosenth requested a review from subotic October 1, 2019 15:59
@lrosenth lrosenth self-assigned this Oct 1, 2019
@subotic subotic changed the title Wip/fix knora json feature: Add mimetype to knora json response Oct 2, 2019
subotic
subotic approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM :-)

@subotic subotic merged commit 81ab98a into develop Oct 2, 2019
@subotic subotic deleted the wip/fix-knora-json branch October 2, 2019 07:52
@daschbot daschbot mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@lrosenth lrosenth

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

knora.json needs to return the file's internal MIME type
2 participants
@lrosenth @subotic