Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better handling of missing sidecar files #376

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fix: better handling of missing sidecar files #376

merged 3 commits into from
Jan 19, 2023

Conversation

subotic
Copy link
Contributor

@subotic subotic commented Jan 19, 2023 •
edited
Loading

  • DEV-903: Sipi returns 500 server error instead of 404, when the sidecar file does not exist.

@subotic subotic self-assigned this Jan 19, 2023
@subotic subotic requested a review from lrosenth January 19, 2023 16:24
@subotic
Copy link
Contributor Author

subotic commented Jan 19, 2023 •
edited
Loading

@lrosenth Could you maybe take a quick look? It does now what I want it to do.

lrosenth
lrosenth approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@lrosenth lrosenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alles OK. std::Springs müssen nicht initialisiert werden (ist eine Klasse die automatisch auf "" gesetzt wird – aber macht nichts. Hingegen die double_t's müssen richtigerweise auf 0.0 gesetzt werden...

@lrosenth lrosenth merged commit bed711f into main Jan 19, 2023
@lrosenth lrosenth deleted the wip/DEV-903-handling-of-missing-sidecar branch January 19, 2023 18:08
@subotic
Copy link
Contributor Author

subotic commented Jan 19, 2023

Alles OK. std::Springs müssen nicht initialisiert werden (ist eine Klasse die automatisch auf "" gesetzt wird – aber macht nichts. Hingegen die double_t's müssen richtigerweise auf 0.0 gesetzt werden...

Danke 👍

@daschbot daschbot mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrosenth lrosenth lrosenth approved these changes

Assignees

@subotic subotic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subotic @lrosenth