feat: use gray instead of black values for transparent parts of image when returning as JPEG #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siers
approved these changes
Mar 5, 2024
BalduinLandolt
approved these changes
Mar 5, 2024
|
@siers and @BalduinLandolt thanks for the review. |
subotic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When returning JPEGs for images that originally had a transparent background and the content was black, the returned JPEG would have black pixels instead of the transparent background as JPEG does not support transparency.
Desired Outcome
Return middle gray instead of the black for transparent parts of the image.
Solution
When a JPEG is requested, where the original image has an alpha channel defined, use the alpha channel information to force black pixels (0) to middle gray (128).