Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow YCbCr/RGB autoconvert, update libtiff (DEV-3863) #451

Merged
merged 9 commits into from
Aug 7, 2024
Merged

feat: Allow YCbCr/RGB autoconvert, update libtiff (DEV-3863) #451

merged 9 commits into from
Aug 7, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Aug 5, 2024

  • patch removed, because it now seems to be fixed in the upstream
  • test-e2e makefile command fixed
  • unit test with the buggy picture added

@siers
feat: Allow YCbCr/RGB autoconvert, update libtiff (DEV-3863)
2b031b0 
* patch removed, because it now seems to be fixed in the upstream
* test-e2e makefile command fixed
* unit test with the buggy picture added
@linear Linear
Copy link

linear bot commented Aug 5, 2024

DEV-3863 Images upload result code 500 error with SIPI

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.5%. Comparing base (df1c34d) to head (7216cbf).

Files Patch % Lines
src/formats/SipiIOTiff.cpp 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
src/formats/SipiIOTiff.cpp 29.1% <0.0%> (+<0.1%) ⬆️

... and 3 files with indirect coverage changes

@siers siers requested a review from subotic August 6, 2024 10:49
subotic
subotic approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siers siers merged commit ccc68bc into main Aug 7, 2024
5 checks passed
@siers siers deleted the fix/DEV-3863 branch August 7, 2024 09:46
@daschbot daschbot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siers @subotic