Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect X-Forwarded-Proto (DEV-3499) #453

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Sep 2, 2024

X-Forwarded-Proto is now being respected in both info.json and knora.json. Repetition slightly reduced. Both are tested in test/e2e.

See also:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto

Copy link

linear bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 22.5%. Comparing base (9463410) to head (7df3a92).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/SipiHttpServer.cpp 0.0% 2 Missing and 4 partials ⚠️
shttps/Connection.cpp 33.3% 0 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
shttps/Connection.h 40.0% <ø> (-1.5%) ⬇️
shttps/Connection.cpp 26.4% <33.3%> (+<0.1%) ⬆️
src/SipiHttpServer.cpp 20.9% <0.0%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes

… also slighly reduce line count like in info.json
@siers siers requested a review from subotic September 4, 2024 06:49
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thank you!

@siers siers merged commit d5eaab3 into main Sep 4, 2024
6 of 7 checks passed
@siers siers deleted the feat/DEV-3499-respect-X-Forwarded-Proto branch September 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants