Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support IIIF Image's API HEAD requests (DEV-4072) #456

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Sep 24, 2024

HEAD requests should return the status code without the body content. E2E Tests included.

Copy link

linear bot commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 22.6%. Comparing base (83c2c94) to head (62dfd22).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/SipiHttpServer.cpp 12.5% 3 Missing and 4 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/SipiHttpServer.cpp 21.0% <12.5%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

@siers siers requested a review from subotic September 24, 2024 09:49
src/SipiHttpServer.cpp Outdated Show resolved Hide resolved
@siers siers force-pushed the feat/DEV-4072-give-head branch from 6389403 to 6b932db Compare September 24, 2024 13:28
@siers siers force-pushed the feat/DEV-4072-give-head branch from 6b932db to 62dfd22 Compare September 24, 2024 13:28
@siers siers merged commit f3a9a96 into main Sep 25, 2024
5 of 7 checks passed
@siers siers deleted the feat/DEV-4072-give-head branch September 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants