Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Watermarks with alpha support and respect to ratio (DEV-4072) #458

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Oct 2, 2024

  • Alpha support for watermarks added.
  • Serialized TIFF in tests and checked that the watermark is applied by checking against a similarity index.
  • Stable watermark position after cropping is unfortunately not supported.
    • Due to progressive loading in JPEG2000, applying the watermark before transformations is not possible.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.6%. Comparing base (f3a9a96) to head (83e5aea).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/SipiImage.cpp 82.7% 2 Missing and 3 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/SipiImage.hpp 24.6% <ø> (ø)
src/formats/SipiIOTiff.cpp 29.1% <ø> (-0.1%) ⬇️
src/SipiImage.cpp 24.2% <82.7%> (+0.8%) ⬆️

... and 4 files with indirect coverage changes

@siers siers requested a review from subotic October 2, 2024 09:48
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good work!

@siers siers merged commit da34f6a into main Oct 8, 2024
7 checks passed
@siers siers deleted the feat/DEV-3299 branch October 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants