Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: height type was uint32 instead of int64 #123

Merged
merged 4 commits into from
Jul 23, 2021
Merged

fix: height type was uint32 instead of int64 #123

merged 4 commits into from
Jul 23, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Jul 22, 2021 •
edited
Loading

Issue being fixed or feature implemented

height's type was uint32 when it should be int64

What was done?

  • updated type

How Has This Been Tested?

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.21.0 milestone Jul 22, 2021
@jawid-h jawid-h requested a review from shumkov July 22, 2021 14:14
@jawid-h jawid-h changed the title fix: height type was uint32 instead of uint64 fix: height type was uint32 instead of int64 Jul 22, 2021
shumkov
shumkov suggested changes Jul 22, 2021
View reviewed changes
protos/platform/v0/platform.proto Outdated
uint32 height = 1;
uint32 core_chain_locked_height = 2;
int64 height = 1;
int64 core_chain_locked_height = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint32

shumkov
shumkov approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawid-h jawid-h merged commit 1a019af into v0.21-dev Jul 23, 2021
@jawid-h jawid-h deleted the feat/uin64 branch July 23, 2021 08:31
This was referenced May 25, 2024
Open
Open
This was referenced Jun 1, 2024
Open
Open
Open
This was referenced Jun 18, 2024
Open
Open
Open
This was referenced Jul 13, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
This was referenced Aug 1, 2024
Open
Open
This was referenced Aug 10, 2024
Open
Open
This was referenced Aug 17, 2024
Open
Open
Open
This was referenced Aug 21, 2024
Open
Open
Open
This was referenced Sep 2, 2024
Open
Open
Open
Open
This was referenced Sep 14, 2024
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Oct 30, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Nov 6, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov