Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: waitForStateTransitionResult endpoint #331

Merged
merged 40 commits into from
Feb 2, 2021
Merged

feat: waitForStateTransitionResult endpoint #331

merged 40 commits into from
Feb 2, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jan 13, 2021 •
edited by antouhou
Loading

Issue being fixed or feature implemented

Add a call that acknowledges the client when the ST was accepted into the block or notifies the user of an error if it wasn't

What was done?

  • Added wsClient for tenderdash
  • waitForStateTransitionResult DAPI endpoint

How Has This Been Tested?

Tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.18 milestone Jan 13, 2021
@antouhou antouhou marked this pull request as ready for review January 19, 2021 09:25
@antouhou @shumkov
Update scripts/api.js
08a59ee 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
antouhou and others added 9 commits January 20, 2021 19:36
@antouhou @shumkov
Update test/integration/grpcServer/handlers/platform/waitForStateTran…
9544a49 
…sitionResultHandlerFactory.js

Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@antouhou @shumkov
Update test/integration/grpcServer/handlers/platform/waitForStateTran…
6d8f0bc 
…sitionResultHandlerFactory.js

Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@antouhou @shumkov
Update test/integration/grpcServer/handlers/platform/waitForStateTran…
2ded36a 
…sitionResultHandlerFactory.js

Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@antouhou @shumkov
Update test/integration/grpcServer/handlers/platform/waitForStateTran…
32e0ae9 
…sitionResultHandlerFactory.js

Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@antouhou
remove duplicated test
907548f
@antouhou
Merge remote-tracking branch 'origin/wait-for-st' into wait-for-st
45ea796
@antouhou
add dpp/DriveStateRepository.js and renamed old class with this name …
f89c546 
…into DriveClient.js; Add waiting interval to waitForStateTransitionResultHandlerFactory.js
@antouhou
add test for waiting for blocks
ad45925
@antouhou
fix waitForStateTransitionResultHandlerFactory.js tests
9f9e39c
@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 2 alerts when merging 9399de0 into d704cf4 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

shumkov
shumkov previously approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, guys! 👍

@shuplenkov shuplenkov merged commit 6612373 into v0.18-dev Feb 2, 2021
@shuplenkov shuplenkov deleted the wait-for-st branch February 2, 2021 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antouhou antouhou antouhou approved these changes

@shumkov shumkov shumkov left review comments

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Milestone
v0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@shuplenkov @shumkov @antouhou