This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
fix: getStatus wrong hashes serialization
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
previously approved these changes
Apr 30, 2021
shumkov
changed the title
getStatus wrong hashes serialization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Hashes in getStatus response being serialized the wrong way
What was done?
Added proper conversion to binary
How Has This Been Tested?
Modified existing test to ensure that fields that supposed to be binaries are binaries
Breaking Changes
Checklist:
For repository code-owners and collaborators only