Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: subscribeToTransactionsWithProofsHandler misses transactions from mempool #375

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

shuplenkov
Copy link
Member

Issue being fixed or feature implemented

If the client was reconnected to subscribeToTransactionsWithProofs or it was connected after transaction was emitted, there will be no instantLock event emitted.

What was done?

Scan mempool for new transactions

How Has This Been Tested?

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov requested a review from shumkov June 28, 2021 15:55
@shuplenkov shuplenkov added this to the v0.20 milestone Jun 28, 2021
@shumkov shumkov changed the title fix: subscribeToTransactionsWithProofsHandler can skip instantLocks events fix: subscribeToTransactionsWithProofsHandler misses transactions from mempool Jun 28, 2021
@shuplenkov shuplenkov marked this pull request as draft June 28, 2021 16:02
@shumkov shumkov changed the title fix: subscribeToTransactionsWithProofsHandler misses transactions from mempool fix: subscribeToTransactionsWithProofsHandler misses transactions from mempool Jun 28, 2021
@shuplenkov shuplenkov marked this pull request as ready for review June 29, 2021 09:02
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit 84f1670 into v0.20-dev Jun 29, 2021
@shuplenkov shuplenkov deleted the fix-subscribe-to-transactions branch June 29, 2021 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants