Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: prove options was set as a string #387

Merged
merged 2 commits into from
Jul 14, 2021
Merged

fix: prove options was set as a string #387

merged 2 commits into from
Jul 14, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Jul 14, 2021

Issue being fixed or feature implemented

prove options was sent to Tenderdash as a string rather than boolean

What was done?

  • changed the type

How Has This Been Tested?

Local setup

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.20 milestone Jul 14, 2021
shumkov
shumkov approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawid-h jawid-h merged commit 8447883 into v0.20-dev Jul 14, 2021
@jawid-h jawid-h deleted the fix/prove-true branch July 14, 2021 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

Assignees
No one assigned
Labels
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov