Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

ci: fix arm64 linker errors #86

Merged
merged 7 commits into from
Mar 15, 2022
Merged

ci: fix arm64 linker errors #86

merged 7 commits into from
Mar 15, 2022

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Mar 12, 2022

Issue being fixed or feature implemented

Building this package failed in CI with the error: linking with `cc` failed: exit status: 1 or similar.

What was done?

Explicitly specify which linker to use for this target and make sure it is installed in build environment.

How Has This Been Tested?

  • Clone dashevo/platform on arm64 device, run yarn install --> fails with rs-drive dep error, "No native build was found"
  • Clone strophy/platform on arm64 with strophy/rs-drive npm dep, run yarn install --> success

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy
Copy link
Contributor Author

strophy commented Mar 12, 2022

This is a bit of a hack because we are repurposing a musl build container to build a gnu binary. All the gnu compilers are present in the x86_64 musl build image though, so I'm not sure why it's not there on arm64. As an alternative, we could change the action to not use a docker container to build instead, but this solution is more simple and consistent with the x86_64 build step.

@strophy strophy requested a review from shumkov March 12, 2022 01:58
@shumkov shumkov changed the title fix(ci): arm64 linker errors in CI ci: fix arm64 linker errors Mar 14, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants