This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
fix: simple transaction do not have any 4 inputs limitation #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not anymore the definition of a simpleTransaction
Co-authored-by: Cofresi <cofresi@dash.org>
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
reviewed
Jun 30, 2020
| @@ -331,7 +331,7 @@ describe('Utils - coinSelection', function suite() { | |||
|
|
|||
| while(inputValue<outputValue){ | |||
| if(copiedUtxos.length === 0){ | |||
| throw new Error('Not enought utxo'); | |||
| throw new Error('Not enought UTXOs'); | |||
There was a problem hiding this comment.
Oops, missed this the first time 🙈
Suggested change
| throw new Error('Not enought UTXOs'); | |
| throw new Error('Not enough UTXOs'); |
There was a problem hiding this comment.
It's already merged, but I do will update that on another PR, I've taken note of it on my todo :) Thank you :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As reported in #157, the SimpleTransactionOptimizedAccumulator strategy was optimising for a maximum of 4 inputs to ensure they get locked. By default, this was the transaction strategy that were being used, so anyone that will try to spend using default options would encounter that case (if using small inputs), and the documentation would not explained the why.
As this rules actually is not in place anymore, we can safely modify the strategy to not put this limitation anymore.
What was done?
How Has This Been Tested?
Rely on differents UTXO selection test we have + additional test in coinSelection file (was already tested in Account.createTransaction)
Breaking Changes
N/A (but won't cause the issue again)
Checklist: