Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

fix: confirmation might come before broadcast ACK #183

Merged
merged 1 commit into from
Sep 3, 2020
Merged

fix: confirmation might come before broadcast ACK #183

merged 1 commit into from
Sep 3, 2020

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 3, 2020 •
edited
Loading

Issue being fixed or feature implemented

Transaction confirmation might come before broadcast ACK in the fundWallet function

What was done?

waitForTransaction calls immediately after broadcast without getting ACK

How Has This Been Tested?

With tests.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou September 3, 2020 11:53
antouhou
antouhou approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 6e0efaf into v0.15-dev Sep 3, 2020
@shumkov shumkov deleted the fix-fund-wallet branch September 3, 2020 12:18
@thephez thephez added this to the v0.15 milestone Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antouhou antouhou antouhou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @antouhou @thephez