Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

fix: transaction sign and OP_RETURN + import #188

Merged
merged 10 commits into from
Oct 8, 2020
Merged

Conversation

Alex-Werner
Copy link
Contributor

@Alex-Werner Alex-Werner commented Sep 21, 2020

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Added provided tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner marked this pull request as ready for review October 7, 2020 03:44
@Alex-Werner Alex-Werner added this to the v0.16 milestone Oct 7, 2020
@Alex-Werner Alex-Werner requested a review from Cofresi October 7, 2020 05:03
shumkov
shumkov previously requested changes Oct 7, 2020
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! I can't wrap my head around why the commits from the #185 ended up in this PR though 🤔 I guess 0.16 was started before we've merged the #185 into the master

@antouhou antouhou changed the base branch from v0.16-dev to master October 7, 2020 11:34
@antouhou antouhou changed the base branch from master to v0.16-dev October 7, 2020 11:34
@antouhou
Copy link
Contributor

antouhou commented Oct 7, 2020

I've updated the 0.16 branch, so now those commits from #185 are gone from this PR 👍

@Alex-Werner Alex-Werner dismissed shumkov’s stale review October 7, 2020 20:42

Fixed by updating 0.16 branch as it was master commit

Copy link
Contributor

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants