Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

feat: is locks subscription #206

Merged
merged 14 commits into from
Dec 8, 2020
Merged

feat: is locks subscription #206

merged 14 commits into from
Dec 8, 2020

Conversation

antouhou
Copy link
Contributor

@antouhou antouhou commented Dec 4, 2020

Issue being fixed or feature implemented

Add instant locks synchronization to be used for identity funding

What was done?

  • Add importInstantLock method to Account class:
    • Imports IS lock to the storage end emits an event
  • Add waitForInstnatLock method to Account class:
    • Return instant locks if it was already imported previously;
    • Waits for import event and returns instant locks after it was imported;
    • Rejects by a timeout;

How Has This Been Tested?

Added integration test to test scenarios above to TransactionStreamWorker

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou marked this pull request as ready for review December 6, 2020 10:37
@antouhou antouhou changed the title Feat is locks feat: is locks subscription Dec 6, 2020
@antouhou antouhou requested review from shuplenkov, Alex-Werner and shumkov and removed request for shuplenkov and Alex-Werner December 6, 2020 10:38
@antouhou antouhou added this to the v0.17 milestone Dec 6, 2020
shuplenkov
shuplenkov previously approved these changes Dec 7, 2020
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

shumkov
shumkov previously approved these changes Dec 7, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@antouhou antouhou dismissed stale reviews from shumkov and shuplenkov via 560654b December 7, 2020 09:06
@antouhou antouhou merged commit 3525090 into v0.17-dev Dec 8, 2020
@antouhou antouhou deleted the feat-is-locks branch December 8, 2020 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants