Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

fix: merkleRootQuorums from the diff doesn’t match calculated quorum root after diff is applied #212

Merged
merged 1 commit into from
Dec 30, 2020
Merged

fix: merkleRootQuorums from the diff doesn’t match calculated quorum root after diff is applied #212

merged 1 commit into from
Dec 30, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Dec 30, 2020

Issue being fixed or feature implemented

Fixing an issue in dashcore-lib: merkleRootQuorums from the diff doesn’t match calculated quorum root after diff is applied

What was done?

  • Updated dashcore-lib

How Has This Been Tested?

On testnet.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested a review from shumkov December 30, 2020 10:46
@jawid-h jawid-h changed the base branch from v0.18-dev to master December 30, 2020 10:46
shumkov
shumkov approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit d6f8287 into master Dec 30, 2020
@shumkov shumkov deleted the fix/dashcore-lib branch December 30, 2020 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov