Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

fix: transaction.isConbase is not a function #246

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

antouhou
Copy link
Contributor

Issue being fixed or feature implemented

transaction.isConbase is not a function when calling account.getUTXOS() when restoring a wallet from the localForage state adapter

What was done?

  • Add hasMethod utility method
  • Wrapped transaction from storage into new Transaction() to parse the transaction if it was serialized

How Has This Been Tested?

  • Add storage adapter mock that behaves similarly to the LocalForage adapter and wrote integration test for the Account#getUTXO method

Breaking Changes

None (probably)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou added this to the v0.18.x milestone Apr 27, 2021
@antouhou antouhou requested review from shumkov and Alex-Werner April 27, 2021 15:00
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@dashevo/wallet-lib",
"version": "7.18.0",
"version": "7.18.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring it back. Version should be bumped in a separate release commit.

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, mate!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants