This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
feat: provide plugin dependencies sorting #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f770f72.
This comment has been minimized.
This comment has been minimized.
Alex-Werner
force-pushed
the
feat/plugin-dependencies
branch
from
d65a40a to
9de1030
Compare
shumkov
reviewed
Sep 14, 2021
shumkov
reviewed
Sep 14, 2021
shumkov
reviewed
Sep 14, 2021
shuplenkov
pushed a commit
that referenced
this pull request
Oct 25, 2021
* feat(Keychain): getHardenedDIP15AccountKey * feat(Plugin): added ability to handle pluginDependency * feat(sortPlugin): manage sorting based on before/after props * fix: resolve plugins * feat: add awaitOnInjection property * Revert "feat(Keychain): getHardenedDIP15AccountKey" This reverts commit f770f72. * fix: removed unused required modules * fix: removed unused required dependency * fix: merge conflict * doc: lint fix * feat: optimisation of sequential insert * test: fix undefined allowSensitiveOperations * fix: multiple before cases * doc: documents plugin injection order usage * fix: lint extra spaces * fix: correctly compare with future position on after case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR provides the ability for plugins to be injected based on a sorting property (before, after).
User's defined plugins get sorted before the injection is being done.
What was done?
How Has This Been Tested?
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only