Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

feat: provide watch-only mode for PublicKey and Address based Wallet #290

Merged
merged 8 commits into from
Sep 1, 2021

Conversation

Alex-Werner
Copy link
Contributor

Issue being fixed or feature implemented

This PR provide ability to init a Wallet from an Address or a PublicKey.

What was done?

  • feat: provide Address and PublicKey instantiation params

How Has This Been Tested?

  • Updated tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner added this to the v0.21.0 milestone Aug 6, 2021
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Alex-Werner Alex-Werner merged commit c729801 into v0.21-dev Sep 1, 2021
@Alex-Werner Alex-Werner deleted the feat/public-key-init branch September 1, 2021 11:57
shuplenkov pushed a commit that referenced this pull request Oct 25, 2021
…290)

* feat: provide watch-only mode for PublicKey and Address based Wallet

* test: fix lint

* tests: adapt test for address and publickKey

* tests: adapt test for address and publickKey

* feat: exportWallet to string only

* test:  fromPublicKey object

* style: fix underscored variable name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants