This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
fix(TransactionSyncWorker): improve stream response handling #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Werner
force-pushed
the
fix/utxo-inclusion
branch
from
September 28, 2021 15:31
e1e8589
to
892ffb1
Compare
Alex-Werner
force-pushed
the
fix/utxo-inclusion
branch
from
September 29, 2021 19:12
1ab6e4d
to
92234ea
Compare
This pull request introduces 1 alert when merging e02a685 into 19a3f68 - view on LGTM.com new alerts:
|
shumkov
reviewed
Oct 4, 2021
shumkov
reviewed
Oct 4, 2021
shumkov
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, guys! 👍
shuplenkov
pushed a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There are several UTXO related bugs:
Also, Due to a bug in
grpc-js
explained here. A temporary solution is used to bypass this bug until a fix is merged into Node.js explained hereWhat was done?
stream.cancel
intosetImmediate
How Has This Been Tested?
Breaking Changes
Fixed a generated value that was faulty as only representing external generated. Any dependency to generated from ensureAddressesToGapLimit utils will need to be updated.
Checklist:
For repository code-owners and collaborators only