This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
fix: avoid trying to cancel already cancelled stream #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Werner
force-pushed
the
fix/abort-cancelling-cancelled-stream
branch
from
ed5b65e to
069718c
Compare
shuplenkov
pushed a commit
that referenced
this pull request
Oct 25, 2021
* fix: avoid trying to cancel already cancelled stream * refactor: remove unnecessary `cancel` method check Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR fixes an issue with TransactionStreamWorker when trying to close an already closed stream which would then throw a
Uncaught TypeError: Cannot read properties of null (reading ‘cancel’)What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only