Commit 303480f
committed
Merge #6997: fix: use proper host objcopy/readelf
4d278c6 fix: shellcheck (pasta)
6700ca9 fix: use proper host objcopy/readelf (pasta)
Pull request description:
## Issue being fixed or feature implemented
Our script didn't use host specific objcopy, so it would crash with not being able to interpret them depending on what we were building on and for.
## What was done?
Use proper objcopy
## How Has This Been Tested?
CI after: https://github.com/PastaPastaPasta/dash/actions/runs/19547578950
CI before: https://github.com/PastaPastaPasta/dash/actions/runs/19544501408
## Breaking Changes
## Checklist:
_Go over all the following points, and put an `x` in all the boxes that apply._
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
ACKs for top commit:
UdjinM6:
utACK 4d278c6
kwvg:
ACK 4d278c6
Tree-SHA512: 6e5a8095deb344187c73579105e30c03db8a834015d335b1c6df69c8d5da0de5157e1771486a123cfdf37b36970e89aabb56d95d5334d428181e84a1bbc1b9a81 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
348 | | - | |
| 348 | + | |
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| |||
354 | 354 | | |
355 | 355 | | |
356 | 356 | | |
357 | | - | |
| 357 | + | |
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
| 377 | + | |
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
383 | | - | |
| 383 | + | |
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
| |||
0 commit comments