fix: proper CacheBlockHeight usage

PastaPastaPasta · PastaPastaPasta · commit 617ed07e9333 · 2025-11-19T10:41:54.000-06:00
diff --git a/src/instantsend/net_instantsend.cpp b/src/instantsend/net_instantsend.cpp
@@ -42,7 +42,7 @@ void NetInstantSend::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
             m_peer_manager->PeerMisbehaving(pfrom.GetId(), 1);
             return;
         }
-        m_is_manager.CacheBlockHeight(blockIndex->GetBlockHash(), blockIndex->nHeight);
+        m_is_manager.CacheBlockHeight(blockIndex);
         cycleHeightOpt = blockIndex->nHeight;
     }
     const int block_height = *cycleHeightOpt;

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void NetInstantSend::ProcessMessage(CNode& pfrom, const std::string& msg_type, C`
`42`	`42`	`m_peer_manager->PeerMisbehaving(pfrom.GetId(), 1);`
`43`	`43`	`return;`
`44`	`44`	`}`
`45`		`- m_is_manager.CacheBlockHeight(blockIndex->GetBlockHash(), blockIndex->nHeight);`
	`45`	`+ m_is_manager.CacheBlockHeight(blockIndex);`
`46`	`46`	`cycleHeightOpt = blockIndex->nHeight;`
`47`	`47`	`}`
`48`	`48`	`const int block_height = *cycleHeightOpt;`