refactor: hide direct usages of GetMetaInfo for net_processing

Author: knst

src/masternode/meta.cpp

@@ -119,6 +119,16 @@ void CMasternodeMetaMan::DisallowMixing(const uint256& proTxHash)
     mm->nMixingTxCount++;
 }
 
+bool CMasternodeMetaMan::IsValidForMixingTxes(const uint256& protx_hash) const
+{
+    LOCK(cs);
+
+    auto it = metaInfos.find(protx_hash);
+    if (it == metaInfos.end()) return true;
+
+    return it->second->IsValidForMixingTxes();
+}
+
 bool CMasternodeMetaMan::AddGovernanceVote(const uint256& proTxHash, const uint256& nGovernanceObjectHash)
 {
     auto mm = GetMetaInfo(proTxHash);
@@ -215,6 +225,24 @@ bool CMasternodeMetaMan::ResetPlatformBan(const uint256& protx_hash, int height)
     return it->second->SetPlatformBan(false, height);
 }
 
+bool CMasternodeMetaMan::SetPlatformBan(const uint256& inv_hash, PlatformBanMessage&& ban_msg)
+{
+    LOCK(cs);
+
+    const uint256& protx_hash = ban_msg.m_protx_hash;
+
+    auto it = metaInfos.find(protx_hash);
+    if (it == metaInfos.end()) {
+        it = metaInfos.emplace(protx_hash, std::make_shared<CMasternodeMetaInfo>(protx_hash)).first;
+    }
+
+    bool ret = it->second->SetPlatformBan(true, ban_msg.m_requested_height);
+    if (ret) {
+        m_seen_platform_bans.insert(inv_hash, std::move(ban_msg));
+    }
+    return ret;
+}
+
 bool CMasternodeMetaMan::AlreadyHavePlatformBan(const uint256& inv_hash) const
 {
     LOCK(cs);
@@ -232,12 +260,6 @@ std::optional<PlatformBanMessage> CMasternodeMetaMan::GetPlatformBan(const uint2
     return ret;
 }
 
-void CMasternodeMetaMan::RememberPlatformBan(const uint256& inv_hash, PlatformBanMessage&& msg)
-{
-    LOCK(cs);
-    m_seen_platform_bans.insert(inv_hash, std::move(msg));
-}
-
 void CMasternodeMetaMan::AddUsedMasternode(const uint256& proTxHash)
 {
     LOCK(cs);

src/masternode/meta.h

@@ -270,6 +270,7 @@ class CMasternodeMetaMan : public MasternodeMetaStore
 
     void AllowMixing(const uint256& proTxHash);
     void DisallowMixing(const uint256& proTxHash);
+    bool IsValidForMixingTxes(const uint256& protx_hash) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
 
     bool AddGovernanceVote(const uint256& proTxHash, const uint256& nGovernanceObjectHash);
     void RemoveGovernanceObject(const uint256& nGovernanceObjectHash) EXCLUSIVE_LOCKS_REQUIRED(!cs);
@@ -284,9 +285,9 @@ class CMasternodeMetaMan : public MasternodeMetaStore
 
     bool IsPlatformBanned(const uint256& protx_hash) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
     bool ResetPlatformBan(const uint256& protx_hash, int height) EXCLUSIVE_LOCKS_REQUIRED(!cs);
+    bool SetPlatformBan(const uint256& inv_hash, PlatformBanMessage&& msg) EXCLUSIVE_LOCKS_REQUIRED(!cs);
     bool AlreadyHavePlatformBan(const uint256& inv_hash) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
     std::optional<PlatformBanMessage> GetPlatformBan(const uint256& inv_hash) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
-    void RememberPlatformBan(const uint256& inv_hash, PlatformBanMessage&& msg) EXCLUSIVE_LOCKS_REQUIRED(!cs);
 
     // CoinJoin masternode tracking
     void AddUsedMasternode(const uint256& proTxHash) EXCLUSIVE_LOCKS_REQUIRED(!cs);

src/net_processing.cpp

@@ -3471,7 +3471,7 @@ std::pair<bool /*ret*/, bool /*do_return*/> static ValidateDSTX(CDeterministicMN
         return {false, true};
     }
 
-    if (!mn_metaman.GetMetaInfo(dmn->proTxHash)->IsValidForMixingTxes()) {
+    if (!mn_metaman.IsValidForMixingTxes(dmn->proTxHash)) {
         LogPrint(BCLog::COINJOIN, "DSTX -- Masternode %s is sending too many transactions %s\n", dstx.masternodeOutpoint.ToStringShort(), hashTx.ToString());
         return {true, true};
         // TODO: Not an error? Could it be that someone is relaying old DSTXes
@@ -3602,10 +3602,8 @@ MessageProcessingResult PeerManagerImpl::ProcessPlatformBanMessage(NodeId node,
     }
 
     // At this point, the outgoing message serialization version can't change.
-    const auto meta_info = m_mn_metaman.GetMetaInfo(ban_msg.m_protx_hash);
-    if (meta_info->SetPlatformBan(true, ban_msg.m_requested_height)) {
-        LogPrintf("PLATFORMBAN -- forward message to other nodes\n");
-        m_mn_metaman.RememberPlatformBan(hash, std::move(ban_msg));
+    if (m_mn_metaman.SetPlatformBan(hash, std::move(ban_msg))) {
+        LogPrintf("PLATFORMBAN -- hash: %s forward message to other nodes\n", hash.ToString());
         ret.m_inventory.emplace_back(MSG_PLATFORM_BAN, hash);
     }
     return ret;