[GUI] Masternodes Tab, sort using Address column

[bertlebbert]

Under the new Masternodes Tab, sorting rows '1rst to last' or 'last to 1rst' by clicking column headings works fine on all but the 'Address' column.

[akijuh]

Works for me. Win7 64bit.

Edit: no its not work right, its sorting but not right order.

[crowning-]

Works perfectly on Win10 64bit and Ubuntu 16.04.
If you're on testnet, do you care to share your masternode.conf?

[bertlebbert]

Actually I noticed this problem under 'All Masternodes' tab,
not sure about 'My Masternodes' tab. I'm on Win7(64 bit):

[bertlebbert]

Haha, that screenshot above is bad example, this screen is better example:
Appears to sort on first digit, such that 216.45.55.146:19999 is < 22.2.250:19999
(not so much of an issue really)

[crowning-]

An IP-address, even when almost always called otherwise, is a string, NOT a number.

And a string (=alphabetical) sort means "216.45" < "23.22.".

Works as designed.

[bertlebbert]

As I say, really not much of an issue - just kinda looks odd... I'll close this then?

[UdjinM6]

Ah, now I see what you meant by "wrong order :) yep, it's just a string and works the same as in Peers tab for example so even if it's a bit confusing it's still consistent :D

I guess it's ok to have it as it is. We can probably implement a more sophisticated sorting for Address column later if there would be many complaints. This however would require to replace current (naive and straightforward) implementation which uses standard widgets with custom model/view implementation and I'm not sure if it really worth it.

Same applies to Active column btw.