Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Withdrawals #2101

Closed
32 tasks done
QuantumExplorer opened this issue Sep 4, 2024 · 1 comment
Closed
32 tasks done

Feat: Withdrawals #2101

QuantumExplorer opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@QuantumExplorer
Copy link
Member

QuantumExplorer commented Sep 4, 2024

Currently in version 1.2 Withdrawals were not enabled. In order to enable withdrawals we need to do the following.

Improvements

  • Create a new protocol version 4.
  • Create a new state transition version of credit withdrawals 1.
  • Write the correct validation as version 1.
  • Review and fix code of credit withdrawals pass 1.
  • Review and fix code of credit withdrawals double check. @shumkov @QuantumExplorer
  • Write unit tests for credit withdrawals.
  • Write strategy tests for credit withdrawals.
  • Set versions of protocol version 4.
  • Write delay of withdrawals till special window.
  • Implement Withdrawal limits.
  • Increase fees for withdrawals to match actual network cost.
  • Write observability mechanisms for withdrawal limits.
  • Write observability mechanisms for withdrawal queue.
  • System to resign expired withdrawals.
  • refactor(drive): remove duplicated withdrawal amount validation #2191
  • feat(sdk): enable withdrawals v1 in JS SDK #2201

Withdrawal contract improvements

Testing

@QuantumExplorer QuantumExplorer added the enhancement New feature or request label Sep 4, 2024
@QuantumExplorer QuantumExplorer self-assigned this Sep 4, 2024
@QuantumExplorer QuantumExplorer moved this to Todo in Platform team Sep 4, 2024
@shumkov
Copy link
Member

shumkov commented Sep 5, 2024

@QuantumExplorer why are you going to introduce a new state transition version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants