Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF] Add Selective Aggregates - Filter #457

Open
jdye64 opened this issue Apr 12, 2022 · 0 comments
Open

[DF] Add Selective Aggregates - Filter #457

jdye64 opened this issue Apr 12, 2022 · 0 comments
Assignees
Labels
datafusion Related to work in DataFusion

Comments

@jdye64
Copy link
Collaborator

jdye64 commented Apr 12, 2022

Is your feature request related to a problem? Please describe.
Apache Datafusion cannot currently parse the Filter syntax of a selective aggregate query. The current implementation with Apache Calcite does support this functionality. We need to add this support to Dask-SQL using Datafusion to ensure that we honor a non-breaking backing SQL implementation.

More information about the Filter clause can be found at Filter Clause Documentation

Describe the solution you'd like
test_groupby.py and aggregate.py currently have commented out code due to this functionality missing in Datafusion. Once Datafusion adds the needed fields and support, Datafusion Issue that code needs to be un-commented and tested for validity. There is likely to be some small refactoring needed in logical.rs and aggregate.rs as well to account for the new Datafusion struct member holding the filtering conditions.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This feature request depends on this Datafusion issue first being resolved.

@jdye64 jdye64 added enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer datafusion Related to work in DataFusion and removed enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Related to work in DataFusion
Projects
None yet
Development

No branches or pull requests

2 participants