Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dask-histogram as part of dask-contrib #154

Closed
douglasdavis opened this issue May 11, 2021 · 10 comments
Closed

dask-histogram as part of dask-contrib #154

douglasdavis opened this issue May 11, 2021 · 10 comments

Comments

@douglasdavis
Copy link
Member

douglasdavis commented May 11, 2021

I've been working on dask-histogram for a little while now and it's "complete" w.r.t. the initial goal (make boost-histogram Dask collection compatible). It's something I'm happy to continue developing, maintaining, and releasing. @jrbourbeau and I had a quick chat about it potentially being a good project for dask-contrib and I'd be happy for it to live there if there are no objections.

@jrbourbeau
Copy link
Member

+1 from me. I think dask-histogram would make a good contrib project. There's an open PR into dask (xref dask/dask#7354) which outlines the criteria for adding a new package to the dask-contrib GitHub org (note that dask-histogram meets all the current criteria). Perhaps this will provide good motivation for us to finish up that document and then move dask-histogram over.

As a side note, if the goal of dask-histogram is to integrate boost-histogram with Dask, you might consider seeing if the boost-histogram developers have an interest in including the functionality from dask-histogram directly in boost-histogram. This type of upstreaming has happened before (e.g. with dask-xgboost and dask-lightgbm) and is likely to increase the visibility of any boost-histogram + Dask capabilities for boost-histogram users. Though this is totally up to you -- I'm just bringing this up as a suggestion.

@jakirkham
Copy link
Member

Also +1 from me

@martindurant
Copy link
Member

I'm sure we have enough votes. @douglasdavis , are you ready to make the move, or are there still conversations elsewhere you wish to clear up first?

@jakirkham
Copy link
Member

Agreed I think the other question is, how we do the transfer? IOW who has permissions on dask-contrib to facilitate this and what does Doug need to do to make the move

@martindurant
Copy link
Member

@jrbourbeau , can you make me an admin on dask-contrib so I can do the move? I assume all dask admins should be dask-contrib admins for this kind of thing.

@jakirkham
Copy link
Member

Agreed would be good to add all admins over there

@douglasdavis
Copy link
Member Author

I'm sure we have enough votes. @douglasdavis , are you ready to make the move, or are there still conversations elsewhere you wish to clear up first?

Just mentioning here that I had a quick chat with Martin confirming I'm ready for it to be moved to dask-contrib, I passed ownership to him in prep for making the move.

@jrbourbeau
Copy link
Member

I've invited John, Martin, Julia, Ben, and Matt to be admins for dask-contrib. If other dask org admins would like to be added, just let me know

@martindurant
Copy link
Member

@jakirkham
Copy link
Member

Thanks all! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants