Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin for preemptible instances. #239

Closed
Timost opened this issue Jan 18, 2021 · 1 comment · Fixed by #251
Closed

Add plugin for preemptible instances. #239

Timost opened this issue Jan 18, 2021 · 1 comment · Fixed by #251

Comments

@Timost
Copy link
Contributor

Timost commented Jan 18, 2021

Hi !

Following some discussions in dask/distributed#4421. I've implemented a worker plugin that calls azure metadata service to check for node eviction in AKS and try to shut down workers as cleanly as possible. @jacobtomlinson suggested I contribute it to this repo in dask/distributed#4421 (comment) somewhere in dask_cloudprovider.azure.utils.

Before opening an MR I would like some pointers on where to put the actual code and the associated documentation.
Thank you.

@jacobtomlinson
Copy link
Member

Thanks for raising this.

I would suggest your Azure code goes in a file called dask_cloudprovider/azure/utils.py with a top-level import in dask_cloudprovider/azure/__init__.py to enable from dask_cloudprovider.azure import PreemptiveWorkerPlugin or whatever you call the class.

Docs should be in the docstring of the class and then exposed in doc/source/azure.rst via an autoclass:: directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants