-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and ensure all notebooks are working #206
Comments
Fortunately, it seems as though prophet has the ability to use the cmdstan backend, which does not require pystan at all. At the moment, this requires manually installing dependencies, but hopefully this will improve. xref facebook/prophet#2041 and facebook/prophet#2088 |
This comment was marked as outdated.
This comment was marked as outdated.
So I put together a With that container, I ran pytest and there were 4 notebooks that failed, presumably due to syntax changes in Dask/Pandas since Dask v2.20? My next task here is to debug those notebooks and fix them up:
One question I had for anyone following along: what to do about the Binder image, in terms of including dependencies of the Notebooks? Several dependencies are installed with |
Another question I have is, what is the purpose of the repo2docker CI job? Does that image get uploaded anywhere, or is it just to see that repo2docker continues to work? I also note that the |
FWIW here, VS Code offers the ability to set up an external folder to store |
Hi dask-examples maintainers! As I'm learning Dask after starting @coiled I thought about adding an example here, or at least doing something that could work in that direction. While getting set up, I noticed that a number of the dependencies of the repo are out-of-date or not available for the
aarch64
/arm64
(Mac M1) platform. Specifically:dask
is pinned to 2.20.0, but 2022.1.1 was released last weekdask-image
is pinned to 0.2.0 but 2021.12.0 is availbledask-ml
is pinned to 1.6.0 but 2022.1.22 is availablepython
is pinned to 3.8 (perhaps because ofpystan
below?)py-xgboost
anddask-xgboost
are either deprecated or not availableaarch64
via conda or PyPIscikit-learn
is pinned to 0.23scikit-image
is installed via pip in the example notebookI'd like to propose updating all these dependencies and putting them into
binder/environment.yml
. Before I get in too deep, especially withprophet
which is likely to be the most complicated one, I'd like some feedback on whether this is desirable and which versions of dependencies (especiallydask-*
libraries) have known conflicts or requirements.On a related, but separate, note, I've been experimenting with creating a
devcontainer
for this repo so that developers can run a full build of the site as they're working. Essentially, this is an add-on for VS Code that mounts a local directory into a pre-configured Docker container that is started by VS Code. All commands and terminals are run inside the container, so it can more-or-less replicate the environment on GH Actions to build the examples via Sphinx and serve them locally.I think this would be a nice helper for anyone who wanted to add a new example, but it would require committing VS Code specific configuration to the repo. Feedback on this idea is welcome as well! Thanks 😃
The text was updated successfully, but these errors were encountered: