Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra and env-extra requirements in core.py #108

Closed
raybellwaves opened this issue Jul 27, 2018 · 3 comments
Closed

Drop extra and env-extra requirements in core.py #108

raybellwaves opened this issue Jul 27, 2018 · 3 comments

Comments

@raybellwaves
Copy link
Member

@mrocklin noted in #78 that all the options in jobqueue.yaml may not to required for local clusters. For example, I haven't used extra and env-extra in development of lsf.py.

At the moment these are required to be in core.py as https://github.com/dask/dask-jobqueue/blob/f7c565a2fe87e8829acba3c752a4da8d196c92ca/dask_jobqueue/core.py#L186L189 requires them.

We could drop these from core.py and require users to specify them in the local clusters.

@raybellwaves raybellwaves changed the title Drop extra and env-extra in core.py Drop extra and env-extra requirements in core.py Jul 27, 2018
@jhamman
Copy link
Member

jhamman commented Jul 27, 2018

I'll come down against this proposal. I am confident that extra/env-extra will be useful to some LSF users. They are a key in adding flexibility to all of the jobqueue Clusters.

@guillaumeeb
Copy link
Member

I'm in line with @jhamman here. I think its a generic functionnality required by some of jobqueue users, that need to stay in core.py.

@raybellwaves
Copy link
Member Author

I can’t say I’m very opinionated on the matter. I’ll let @mrocklin chime in. Otherwise, welcome to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants