Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart doesn't include any roles #479

Closed
jacobtomlinson opened this issue May 12, 2022 · 2 comments
Closed

Helm chart doesn't include any roles #479

jacobtomlinson opened this issue May 12, 2022 · 2 comments
Labels

Comments

@jacobtomlinson
Copy link
Member

The helm chart for the operator that was added in #452 has a service account but no roles. This means the chart doesn't work out of the box. The chart has been published in the latest release (2022.5.0) and is available at https://helm.dask.org. But we don't currently document it.

@samdyzon do you have thoughts about how the operator installed via the chart will authenticate with the cluster? Should we add roles or did you have something else in mind?

It would also be good to document using the helm chart.

@samdyzon
Copy link
Contributor

Looks like I've forgotten to add the service account roles to the helm chart - I totally thought I did that, sorry! To fix this, I can put together a PR which by default creates a service account which has the same roles and role bindings as the manifest in dask_kubernetes/operator/deployment/manifests/operator.yaml - if a user decides to override the values.yaml file to not create a serviceAccount by default, they will be required to provide their own roles/rolebindings.

@jacobtomlinson
Copy link
Member Author

Closed in #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants