Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Deprecate np.array fallback for ParallelPostFit predict function #875

Closed
VibhuJawa opened this issue Nov 4, 2021 · 1 comment
Closed

Comments

@VibhuJawa
Copy link
Collaborator

VibhuJawa commented Nov 4, 2021

We should np.array fallback when meta is None in ParallelPostFit predict in future releases to match dask's preferred behavior.

With PR #862 we add a meta argument to predict call and added a future warning about predict's meta fallback to np.array.

As per discussion here we should deprecate this fallback behavior in future releases.

With PR we added @pytest.mark.filterwarnings("ignore::FutureWarning") to some pytests to prevent pytest failure due to Future warning. (See the PR for details) . We should remove those when we remove the fallback.

Also remove the warnings ignored in documentation at commint 6c29844

CC: @TomAugspurger , @quasiben , @jakirkham

@VibhuJawa
Copy link
Collaborator Author

Closing issue cause we removed this behavior in #862 .

See comment for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant