-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flicker on page change/refresh on Firefox #17
Comments
@jrbourbeau @jacobtomlinson any thoughts? |
Someone internal pointed me to this: https://webhint.io/scanner/026e513b-8f02-44e6-a441-24a9f6f6cb85 Not sure how to interpret all the results, but there's a few things on there that look worth fixing. |
Google lighthouse is also useful for this Looking at the page source it seems there is a lot of JavaScript that gets loaded before the CSS. So this is likely to be a JavaScript performance issue. Ordinarily these script tags should go at the end of the body unless there is an exceptional reason why then are needed before the rest of the DOM. |
It looks like this needs to be changed upstream in rtd. @jcrist can you test the upstream theme and see if you can reproduce the same issue? https://sphinx-rtd-theme.readthedocs.io/en/stable/ I'm not sure why I can't reproduce it on my machine, much be some caching somewhere that is speeding things up for me enough that it doesn't happen. |
Ref readthedocs/sphinx_rtd_theme#853 (may replace 847) |
I think we can probably close this issue, now that we depend on the executable books theme. |
This may be an issue with the readthedocs theme instead of dask's. On firefox, I see a very noticeable flicker on page load for any dask docs page (for example https://docs.dask.org/en/latest/). It looks like this is the CSS formatting (briefly see what looks like a less formatted page). I use firefox as my primary browser, in most cases page load fast and cleanly, so I assume there's something weird with this page leading to this behavior. I am not a web dev, no idea how to investigate this further.
The text was updated successfully, but these errors were encountered: