Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker on page change/refresh on Firefox #17

Closed
jcrist opened this issue Sep 18, 2019 · 7 comments
Closed

Flicker on page change/refresh on Firefox #17

jcrist opened this issue Sep 18, 2019 · 7 comments

Comments

@jcrist
Copy link
Member

jcrist commented Sep 18, 2019

This may be an issue with the readthedocs theme instead of dask's. On firefox, I see a very noticeable flicker on page load for any dask docs page (for example https://docs.dask.org/en/latest/). It looks like this is the CSS formatting (briefly see what looks like a less formatted page). I use firefox as my primary browser, in most cases page load fast and cleanly, so I assume there's something weird with this page leading to this behavior. I am not a web dev, no idea how to investigate this further.

out

@mrocklin
Copy link
Member

@jrbourbeau @jacobtomlinson any thoughts?

@jcrist
Copy link
Member Author

jcrist commented Sep 18, 2019

Someone internal pointed me to this: https://webhint.io/scanner/026e513b-8f02-44e6-a441-24a9f6f6cb85

Not sure how to interpret all the results, but there's a few things on there that look worth fixing.

@jacobtomlinson
Copy link
Member

Google lighthouse is also useful for this

https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fdocs.dask.org%2Fen%2Flatest&tab=desktop

Looking at the page source it seems there is a lot of JavaScript that gets loaded before the CSS. So this is likely to be a JavaScript performance issue. Ordinarily these script tags should go at the end of the body unless there is an exceptional reason why then are needed before the rest of the DOM.

image

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Oct 16, 2019

It looks like this needs to be changed upstream in rtd.

@jcrist can you test the upstream theme and see if you can reproduce the same issue? https://sphinx-rtd-theme.readthedocs.io/en/stable/

I'm not sure why I can't reproduce it on my machine, much be some caching somewhere that is speeding things up for me enough that it doesn't happen.

@jacobtomlinson
Copy link
Member

Ref readthedocs/sphinx_rtd_theme#847

@jacobtomlinson
Copy link
Member

Ref readthedocs/sphinx_rtd_theme#853 (may replace 847)

@jsignell
Copy link
Member

jsignell commented Oct 5, 2021

I think we can probably close this issue, now that we depend on the executable books theme.

@jsignell jsignell closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants