Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Comm for asyncio #2162

Closed
mrocklin opened this issue Aug 5, 2018 · 4 comments
Closed

Implement Comm for asyncio #2162

mrocklin opened this issue Aug 5, 2018 · 4 comments

Comments

@mrocklin
Copy link
Member

mrocklin commented Aug 5, 2018

In some benchmarks that involve many small messages I've found that we spend a non-trivial amount of time in Tornado's IOStream code (see stack overflow question). I've become a bit curious about uvloop. One way to explore this would be to implement a Comm and Backend (see docs) for asyncio and then see how it performs both alone, and after installing uvloop as the default event loop.

cc @pitrou who may have some high-level guidance about whether or not this is a good idea and how best to implement this with asyncio, and @jcrist who might enjoy doing this work.

@mrocklin
Copy link
Member Author

mrocklin commented Aug 6, 2018

I'm playing around with this today, but don't expect to get particularly far.

@mrocklin
Copy link
Member Author

mrocklin commented Aug 6, 2018

Today I got as far as this branch: master...mrocklin:asyncio-comm

This look ok, but unsurprisingly don't function correctly.

@jakirkham
Copy link
Member

Maybe it's worth opening the PR anyways so it is easier to discuss (even if it doesn't totally work yet).

@jcrist
Copy link
Member

jcrist commented Nov 16, 2021

Closing, duplicate of #4513.

@jcrist jcrist closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants