Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate iscoroutinefunction/is_coroutine_function function #4482

Closed
jakirkham opened this issue Feb 4, 2021 · 0 comments · Fixed by #4481
Closed

Duplicate iscoroutinefunction/is_coroutine_function function #4482

jakirkham opened this issue Feb 4, 2021 · 0 comments · Fixed by #4481

Comments

@jakirkham
Copy link
Member

Appears we define this same function with slightly different names twice. If we need the two names, maybe one can be an alias. Otherwise maybe we drop one

def is_coroutine_function(f):
return asyncio.iscoroutinefunction(f) or gen.is_coroutine_function(f)

def iscoroutinefunction(f):
return inspect.iscoroutinefunction(f) or gen.is_coroutine_function(f)

cc @ian-r-rose @mrocklin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant