Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in SpecCluster.close when closing while upscaling #5876

Open
fjetter opened this issue Feb 28, 2022 · 0 comments
Open

Race condition in SpecCluster.close when closing while upscaling #5876

fjetter opened this issue Feb 28, 2022 · 0 comments
Labels
adaptive All things relating to adaptive scaling

Comments

@fjetter
Copy link
Member

fjetter commented Feb 28, 2022

There is a race condition in SpecCluster.close that can lock potentially indefinitely if a cluster is closing while instances are spawned at the same time. It is not clear, yet, if this deadlock resolves itself given enough time.

This has been diagnosed as a root cause for some of the flaky tests, see #4859 (comment)

As a user I would expect an ongoing scale up attempt to be canceled during cluster closing and the closing to take care of cleaning up all already created instances.

@fjetter fjetter added the adaptive All things relating to adaptive scaling label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adaptive All things relating to adaptive scaling
Projects
None yet
Development

No branches or pull requests

1 participant