You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This in turn prevents garbage collection of otherwise released objects, which in turn prevents testing for proper garbage collection as requested in #6250. One possible solution has been sketched out in #6345, namely maintaining a registry of active callbacks, which can be used to cancel all active callbacks on close.
Instead of implementing this solution in the various places where it is needed, I'd suggest moving away from tornado while we are adjusting the callbacks and relying on asyncio.Tasks that we store in a background task registry introduced and cleaned on ServerNode or Server.
The text was updated successfully, but these errors were encountered:
As mentioned in https://github.com/dask/distributed/pull/6246/files#r861616968,
call_later
andadd_callback
maintain references unless cancelled. We do not properly cancel callbacks in particular when closingScheduler
,Nanny
orWorker
instances. See below for an example:(This reference chain was created with
objgraph.find_backref_chain
https://mg.pov.lt/objgraph/#memory-leak-example)This in turn prevents garbage collection of otherwise released objects, which in turn prevents testing for proper garbage collection as requested in #6250. One possible solution has been sketched out in #6345, namely maintaining a registry of active callbacks, which can be used to cancel all active callbacks on close.
Instead of implementing this solution in the various places where it is needed, I'd suggest moving away from
tornado
while we are adjusting the callbacks and relying onasyncio.Task
s that we store in a background task registry introduced and cleaned onServerNode
orServer
.The text was updated successfully, but these errors were encountered: