Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test_restart_fast_sync and test_fast_kill #6746

Closed
gjoseph92 opened this issue Jul 20, 2022 · 0 comments · Fixed by #6750
Closed

Flaky test_restart_fast_sync and test_fast_kill #6746

gjoseph92 opened this issue Jul 20, 2022 · 0 comments · Fixed by #6750
Assignees
@gjoseph92
Labels
flaky test Intermittent failures on CI.

Comments

@gjoseph92
Copy link
Collaborator

gjoseph92 commented Jul 20, 2022 •
edited
Loading

These tests are going to be flaky after #6714. They were relying on restart having a hardcoded 10s timeout and not waiting for all workers. We should probably also rethink the purpose/implementation of these tests—what is the "fast" aspect meant to actually be testing? Maybe restart is no longer the appropriate way to test this fastness?

cc @hendrikmakait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjoseph92 gjoseph92

Labels
flaky test Intermittent failures on CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove test_restart_fast_sync, test_fast_kill gjoseph92/distributed
1 participant
@gjoseph92