Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine performance metrics: seceded tasks #7675

Open
crusaderky opened this issue Mar 17, 2023 · 0 comments
Open

Fine performance metrics: seceded tasks #7675

crusaderky opened this issue Mar 17, 2023 · 0 comments

Comments

@crusaderky
Copy link
Collaborator

As of #7586, seceded tasks don't receive any special treatment. This means that, when there are seceded tasks, the sum of Worker.digests_total["execute", *, *, "seconds"] could exceed the number of threads * worker uptime.

Add special consideration for seceded and rejoined tasks, so that only the time that is spent while not seceded goes into Worker.digests_total["execute", *, *, "seconds"].

Bonus deliverable

A CPU-heavy seceded task can cause regular tasks to exhibit a very high thread-noncpu time.
Measure CPU usage (time.thread_time()) while seceded and log it somewhere separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant