Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test_send_metrics_to_scheduler #8068

Closed
fjetter opened this issue Aug 3, 2023 · 1 comment · Fixed by #8069
Closed

Flaky test_send_metrics_to_scheduler #8068

fjetter opened this issue Aug 3, 2023 · 1 comment · Fixed by #8069
Assignees
Labels
flaky test Intermittent failures on CI.

Comments

@fjetter
Copy link
Member

fjetter commented Aug 3, 2023

This test is a little too specific and is flaking

I do see various different errors like

E         At index 13 diff: ('get-data', 'network', 'seconds') != ('execute', None, 'x', 'memory-read', 'count')
E         Full diff:
E           [
E            ('execute', None, 'x', 'deserialize', 'seconds'),
E            ('execute', None, 'x', 'thread-cpu', 'seconds'),
E            ('execute', None, 'x', 'thread-noncpu', 'seconds'),
E            ('execute', None, 'x', 'executor', 'seconds'),
E            ('execute', None, 'x', 'other', 'seconds'),
E            ('get-data', 'memory-read', 'count'),
E            ('get-data', 'memory-read', 'bytes'),
E            ('get-data', 'serialize', 'seconds'),
E            ('get-data', 'compress', 'seconds'),
E            ('gather-dep', 'decompress', 'seconds'),
E            ('gather-dep', 'deserialize', 'seconds'),
E            ('gather-dep', 'network', 'seconds'),
E            ('gather-dep', 'other', 'seconds'),
E         +  ('get-data', 'network', 'seconds'),
E            ('execute', None, 'x', 'memory-read', 'count'),
E            ('execute', None, 'x', 'memory-read', 'bytes'),
E         -  ('get-data', 'network', 'seconds'),
E           ]

I do not think these tests should assert every single message.

The test report does not show any failure but I can reproduce this on main by running it many times concurrently.

cc @crusaderky

@fjetter fjetter added the flaky test Intermittent failures on CI. label Aug 3, 2023
@fjetter
Copy link
Member Author

fjetter commented Aug 3, 2023

This #8049 seems to make things worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants