Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

fix duplicate file drop #15

Closed
juliangruber opened this issue Jun 9, 2016 · 7 comments
Closed

fix duplicate file drop #15

juliangruber opened this issue Jun 9, 2016 · 7 comments

Comments

@juliangruber
Copy link
Collaborator

No description provided.

@juliangruber
Copy link
Collaborator Author

this issue is being worked on in hyperdrive: holepunchto/hyperdrive#63

@juliangruber juliangruber changed the title fix duplicate data drop fix duplicate file drop Jun 19, 2016
@okdistribute
Copy link
Collaborator

what is the issue here? will this be fixed by the recent changes to hyperdrive-import-files?

@juliangruber
Copy link
Collaborator Author

I'm 50/50 on this one...on one hand it would be nice to de dupe files, on the other hand, hashing everything is too expensive and simply relying on mtimes for deduping isn't safe. I'd say we should make the stack work in a way that it doesn't matter really, even if a file is added again.

@juliangruber
Copy link
Collaborator Author

@mafintosh what do you think about this one? ^

@Kriesse
Copy link
Collaborator

Kriesse commented Oct 21, 2016

ping @mafintosh @juliangruber any update on this?

@Kriesse Kriesse modified the milestone: 1.1.0 Stabilize Oct 21, 2016
@okdistribute okdistribute self-assigned this Nov 12, 2016
@Kriesse
Copy link
Collaborator

Kriesse commented Dec 15, 2016

ping @juliangruber – not sure what's the status here?

@okdistribute okdistribute removed their assignment Dec 15, 2016
@juliangruber
Copy link
Collaborator Author

this is not for dat desktop to solve, it's a hyper* issue. closing here as we haven't settled on a solution yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants