Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataall IAM AssetsFileRole to checkov baseline #1188

Open
mourya-33 opened this issue Apr 18, 2024 · 2 comments
Open

Add dataall IAM AssetsFileRole to checkov baseline #1188

mourya-33 opened this issue Apr 18, 2024 · 2 comments

Comments

@mourya-33
Copy link
Contributor

Describe the bug

CDK automatically creates an IAM Role - AssetsFileRole for managing the Assets stage in the main cicd code pipeline. However, this role has a default policy with the following unrestricted IAM permissions that are flagged by checkov scans.

{
"Action": [
"codebuild:BatchGetBuilds",
"codebuild:StartBuild",
"codebuild:StopBuild"
],
"Effect": "Allow",
"Resource": "*"
}

This needs to be added to the checkov baseline until remediated.

How to Reproduce

While deploying dataall to AWS, after the cdk synth, scan the file - cdk.out/dataall-main-cicd-stack.template.json with checkov. Checkov will have a FAILURE with the following message

Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
FAILED for resource: AWS::IAM::Policy.dataallmaincdkpipelineAssetsFileRoleDefaultPolicy{Hash}
File: /dataall-main-cicd-stack.template.json: {line number}
Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-do-not-allow-write-access-without-constraint

Expected behavior

Once the role is added to checkov baseline, the checkov scan should no longer have a FAILURE message for the AssetsFileRole.

Your project

No response

Screenshots

No response

OS

Mac

Python version

3.10

AWS data.all version

2.3

Additional context

This issue is related to #877

@dlpzx
Copy link
Contributor

dlpzx commented Apr 24, 2024

Thanks for opening an issue @mourya-33. I assigned you to the issue, let us know if you need any support

@mourya-33
Copy link
Contributor Author

Thanks Adriana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants