Generic way to toggle data.all features

[blitzmohit]

Is your feature request related to a problem? Please describe.
I'm trying to turn off certain features that are not needed in our instance of data.all

Describe the solution you'd like
Ability to turn off/disable features via a single configuration, with support for the following features:

1. Pipelines
2. ML Studio
3. Notebooks
4. Worksheets

For the implementation it should include the following:

• Documented set of features that can be toggled
• Ability to toggle stacks, i.e. if the feature is disabled the related stack is not created
• Ability to toggle Backend APIs
• Ability to toggle Frontend UI components

[dlpzx]

Hi @blitzmohit, this task is tackled in the modularization work that is on-going for the backend and frontend.

From your points:

• Documented set of features that can be toggled --> not yet, we will finish the modularization and then we will document every module.
• Ability to toggle stacks, i.e. if the feature is disabled the related stack is not created --> part of backend modularization
• Ability to toggle Backend APIs --> part of backend modularization
• Ability to toggle Frontend UI components --> part of frontend modularization

Here is a list of PRs where this work has been done or is in progress:

• backend modularization initial PR - modularization: backend Pluginarchitecture #359

• frontend modularization plan - modularization-frontend: opt into modularization structure #411

• frontend enable/disable - modularization-frontend: enable/disable modules #415

• Notebooks backend modularization - modularization: backend Pluginarchitecture #359

• Notebooks frontend modularization - modularization-frontend: notebook modularization #414

• Dataset backend modularization - modularization: Dataset Modularization pt.1  #413 , modularization: Datasets modularization pt.2 #432 , modularization: Datasets modularization pt.3 #440 , modularization: Datasets modularization pt.4 #441

• Worksheets backend modularization - modularization: Worksheets modularization #449

• MLStudio backend modularization - modularization: Mlstudio modularization #448

• Pipelines backend modularization - modularization: Datapipelines modularization #457

[blitzmohit]

Thanks @dlpzx for sharing the detailed list. As discussed I am using the modularization-main branch now.

For toggling of features inside the backend modules, I have been testing with a decorator similar to ones defined in permission_checker, this would read the property specified from the global config (dataall.core.config) and can be added to specific resolvers we need to disable. Sample code: https://github.com/awslabs/aws-dataall/compare/modularization-main...blitzmohit:modularization_feature_toggle?expand=1#diff-1d8a290d70ece43c4e742c1abefdff15ea551fb035528e0c17347eb388141e1aR1-R21

@noah-paige @dlpzx Please share your thoughts on the approach & any other recommendations on how feature toggling would work inside the modules or even core if needed.

[noah-paige]

The above issue is addressed in the following PRs:

• Add generic way to toggle data.all features #538
• feat: adding frontend and backend feature flags #817

Closing this issue as complete!