S3 Bucket policy update behavior

[dlpzx]

For imported Datasets, data.all does not create an S3 Bucket policy. We want to know what would happen if:

• we add a baseline bucket policy in the dataset stack that has a baseline policy (bucket-policy-1) This is useful to add baseline bucket policies, for example ensuring secure transport
• we import an S3 Bucket that has a bucket policy (bucket-policy-0)

Is our bucket-policy-1 going to replace bucket-policy-0? or is it going to give errors?

[mourya-33]

Hi @dlpzx ,The original policy on the bucket is overwritten by the policy from the data.all stack.

Test steps:

1. Create bucket with a bucket policy - bucket-policy-0
2. Import the bucket to data.all
3. Data.all will deploy the cloudformation stack to import the bucket and add bucket policy for HTTPs - bucket-policy-1
4. Once the stack completes, verify the bucket policy. The policy will now be bucket-policy-1 instead of the original bucket-policy-0

[dlpzx]

Thanks @mourya-33 for having a look, very valuable for #284 :)